Quality-of-life improvements #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
approved these changes
Feb 22, 2020
plato/draw/Scene.py
Outdated
| Primitives can also be accessed in the order they were added to | ||
| the scene using list-like syntax:: | ||
|
|
||
| first_prim = scene[:3] |
There was a problem hiding this comment.
Suggested change
| first_prim = scene[:3] | |
| first_three_prims = scene[:3] |
| @@ -1,8 +1,20 @@ | |||
| import contextlib | |||
There was a problem hiding this comment.
Not sure why this import is separated from the others. Maybe combine this (no empty newline).
plato/draw/matplotlib/Scene.py
Outdated
| import matplotlib.pyplot as pp | ||
| from matplotlib.collections import PatchCollection | ||
| from ... import draw | ||
| import numpy as np | ||
|
|
||
| @contextlib.contextmanager | ||
| def manage_matplotlib_interactive(): | ||
| import matplotlib.pyplot |
There was a problem hiding this comment.
This was already imported above -- use pp.isinteractive(), etc.
| @@ -97,4 +109,7 @@ def save(self, filename): | |||
| return figure.savefig(filename, dpi=figure.dpi) | |||
|
|
|||
| def _ipython_display_(self): | |||
| return self.show() | |||
| import IPython.display | |||
There was a problem hiding this comment.
I would prefer imports at the top of the module unless this is a "soft" dependency.
plato/draw/pythreejs/Scene.py
Outdated
| @@ -180,7 +180,8 @@ def enable(self, name, auto_value=None, **parameters): | |||
|
|
|||
| def show(self): | |||
| import IPython | |||
There was a problem hiding this comment.
This imports IPython while other modules imported IPython.display.
|
|
||
| self.assertIs(scene[0], prim0) | ||
| self.assertIs(scene[-1], prim1) | ||
| self.assertEqual(scene[:3], [prim0, prim1]) |
There was a problem hiding this comment.
I'd like to add one more test line:
Suggested change
| self.assertEqual(scene[:3], [prim0, prim1]) | |
| self.assertEqual(scene[:2], [prim0, prim1]) | |
| self.assertEqual(scene[:3], [prim0, prim1]) |
This change calls IPython.display.display(..., display_id=<>) for many of the types of scenes, which causes jupyter to update the scene if it has been displayed already.
klarh
force-pushed
the
ipython_display_id
branch
from
22916e7 to
467c6e5
Compare
|
Good suggestions, thanks @bdice! |
This should make the broadcasting behavior of the various backends more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the treatment of a few relatively minor issues.
display_idforIPython.display.displaycalls inScene.show()for many backends. This causes IPython to automatically clear the location where the scene was previously displayed.mesh.unfoldProperties. This should fix most of the confusion cases when only one particle gets drawn (see pythreejs backend not replicating properties #11), although it isn't the most elegant solution.Sceneobjects by integers or slices to get primitives. Part of Quality-of-life improvements #49.